Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log lines from DAG walking should not appear #67

Closed
BrianHicks opened this issue Jun 10, 2016 · 2 comments
Closed

log lines from DAG walking should not appear #67

BrianHicks opened this issue Jun 10, 2016 · 2 comments
Assignees
Milestone

Comments

@BrianHicks
Copy link
Contributor

since changing to AcyclicGraph.Walk from AcyclicGraph.DepthFirstWalk, we're getting some debug log spam. This needs to be taken care of in the root cmd. We probably should just switch to the stdlib logging package and drop logrus because of this.

@BrianHicks BrianHicks added this to the 0.1.1 milestone Jun 10, 2016
@langston-barrett
Copy link
Contributor

What's the motivation for dropping logrus? Can we not just add a flag (maybe --log-level) that defaults to info or warn and set the logrus level from there?

@BrianHicks
Copy link
Contributor Author

Terraform uses the default logger. We're using their DAG. We'd have to redirect it in awkward ways. Better to just adapt for now.

@BrianHicks BrianHicks self-assigned this Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants