TRY002 does not take into account BaseException

[epenet]

Spotted in home-assistant/core#123021

It seems that pylint doesn't like Exception nor BaseException
https://pylint.pycqa.org/en/latest/user_guide/messages/warning/broad-exception-raised.html

But ruff is quite happy to let BaseException pass

I think both should trigger a warning, same as regular Exception

It should be an easy fix in

ruff/crates/ruff_linter/src/rules/tryceratops/rules/raise_vanilla_class.rs

Line 71 in a3e67ab

if checker.semantic().match_builtin_expr(node, "Exception") {

[dylwil3]

I think Ruff is correctly reproducing the rule from tryceratops, which is implemented here.

The pylint rule --overgeneral-exceptions used to coincide with this rule but has since changed in two ways:

• The rule is now configurable, so the user can specify which exceptions are too general.
• The default configuration includes BaseException.

So I think this needs a decision from the maintainers. Should we:

1. Add BaseException to the TRY002 violation and call it a day (this would disagree with tryceratops).
2. Create a new rule in Pylint (not sure how to find the code) where Exception and BaseException both give violations.
3. Same as (2) but make it configurable as in Pylint.
4. Same as (3) and then also remove/redirect TRY0002.
5. Something else.