Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do you plan on keeping up with new rules/fixes in core ? #2322

Closed
Crocmagnon opened this issue Jan 29, 2023 · 4 comments
Closed

How do you plan on keeping up with new rules/fixes in core ? #2322

Crocmagnon opened this issue Jan 29, 2023 · 4 comments
Labels
question Asking for support or clarification

Comments

@Crocmagnon
Copy link

This is more a general question rather than a feature request/bug report:

How do you plan on keeping up to date with evolving projects you reimplemented in core, like pyupgrade for example?

@charliermarsh
Copy link
Member

The goal is to maintain parity as those projects evolve, to the degree that we can. We've already reimplemented some upstream fixes from flake8-bugbear, for example.

Many of the plugins we've reimplemented, though, are pretty "stable", in that they tend not to add many additional rules. E.g., many of them haven't seen new releases in the past few years. That's not true of all of them, but at least a handful.

pyupgrade is maybe an interesting case, because we don't really support pre-Python 3.7 code. So I'd probably not prioritize anything that was added to pyupgrade that was focused on 2-to-3 conversions. (We do have some of that, like six import removal, but in hindsight I wouldn't have prioritized adding it.) On the other hand, there's a lot of stuff in pyupgrade that's useful for the ongoing maintenance of Python 3 code, like the type annotation rules. So I would pull in new rules of that nature.

@charliermarsh charliermarsh added the question Asking for support or clarification label Jan 29, 2023
@charliermarsh
Copy link
Member

Hopefully that answers your question, but obviously happy to field any follow-ups :)

@Crocmagnon
Copy link
Author

Great! Thanks for your answer 😊

Yeah my question about pyupgrade was more focused on the ongoing development for new Python versions as I don’t see this tool be « finished » like maybe isort or some other could be (I mean once you’ve sorted your imports everything else is bug fixing, … right ? 😁)

And thanks for ruff! It’s an amazing piece of software 😊 I incorporated it in my own projects coming from flakeheaven and the transition was smooth. I don’t have large codebases but it feels a lot snappier already.

@charliermarsh
Copy link
Member

Amazing, so glad to hear that it's working for you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Asking for support or clarification
Projects
None yet
Development

No branches or pull requests

2 participants