Allow system Python discovery with --target and --prefix

astral-sh · Nov 22, 2024 · fdb9185 · fdb9185
1 parent 536d038
commit fdb9185
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 16 deletions.
diff --git a/crates/uv/src/commands/pip/install.rs b/crates/uv/src/commands/pip/install.rs
@@ -139,14 +139,17 @@ pub(crate) async fn pip_install(
         .collect();
 
     // Detect the current Python interpreter.
-    let environment = PythonEnvironment::find(
-        &python
-            .as_deref()
-            .map(PythonRequest::parse)
-            .unwrap_or_default(),
-        EnvironmentPreference::from_system_flag(system, true),
-        &cache,
-    )?;
+    let environment = {
+        let mutable = !(target.is_some() || prefix.is_some());
+        PythonEnvironment::find(
+            &python
+                .as_deref()
+                .map(PythonRequest::parse)
+                .unwrap_or_default(),
+            EnvironmentPreference::from_system_flag(system, mutable),
+            &cache,
+        )?
+    };
 
     report_target_environment(&environment, &cache, printer)?;
 

diff --git a/crates/uv/src/commands/pip/sync.rs b/crates/uv/src/commands/pip/sync.rs
@@ -123,14 +123,17 @@ pub(crate) async fn pip_sync(
     }
 
     // Detect the current Python interpreter.
-    let environment = PythonEnvironment::find(
-        &python
-            .as_deref()
-            .map(PythonRequest::parse)
-            .unwrap_or_default(),
-        EnvironmentPreference::from_system_flag(system, true),
-        &cache,
-    )?;
+    let environment = {
+        let mutable = !(target.is_some() || prefix.is_some());
+        PythonEnvironment::find(
+            &python
+                .as_deref()
+                .map(PythonRequest::parse)
+                .unwrap_or_default(),
+            EnvironmentPreference::from_system_flag(system, mutable),
+            &cache,
+        )?
+    };
 
     report_target_environment(&environment, &cache, printer)?;