Revised activate script fails on alpine:edge

[charliermarsh]

This change caused our CI to fail using alpine:edge image

web-1  | /srv/scripts/run.sh: /srv/.venv/bin/activate: line 81: OSTYPE: parameter not set

Originally posted by @andypost in #10397 (comment)

[zanieb]

I can't reproduce this

FROM alpine:edge

RUN apk add --update --no-cache python3

COPY --from=ghcr.io/astral-sh/uv:0.5.17 /uv /uvx /bin/
RUN uv venv /venv
RUN . /venv/bin/activate

[zanieb]

@andypost am I using a different image or shell than you?

[andypost]

@zanieb the way to reproduce is set -eux before activation

FROM alpine:edge

RUN apk add --update --no-cache python3

COPY --from=ghcr.io/astral-sh/uv:0.5.17 /uv /uvx /bin/
RUN uv venv /venv
RUN set -eux && . /venv/bin/activate

the log

0.710 + . /venv/bin/activate                                                                                                                                                                                                                                 
0.712 + '[' -n  ]
0.712 + '[' -n  ]
0.712 + '[' -n  ]
0.713 + deactivate nondestructive
0.714 + unset -f pydoc
0.714 + '[' -n  ]
0.714 + '[' -n  ]
0.714 + hash -r
0.714 + '[' -n  ]
0.714 + unset VIRTUAL_ENV
0.714 + unset VIRTUAL_ENV_PROMPT
0.714 + '[' '!' nondestructive '=' nondestructive ]
0.715 + VIRTUAL_ENV=/venv
0.715 /bin/sh: /venv/bin/activate: line 81: OSTYPE: parameter not set

[zanieb]

Thanks! Looks like this can be resolved with

RUN sed -i 's/if { \[ "$OSTYPE" = "cygwin" \] || \[ "$OSTYPE" = "msys" \]; }/if { [ "${OSTYPE-}" = "cygwin" ] || [ "${OSTYPE-}" = "msys" ]; }/' /venv/bin/activate

or

❯ gd
diff --git a/crates/uv-virtualenv/src/activator/activate b/crates/uv-virtualenv/src/activator/activate
index 3678ee23b..f87ca81dd 100644
--- a/crates/uv-virtualenv/src/activator/activate
+++ b/crates/uv-virtualenv/src/activator/activate
@@ -78,7 +78,7 @@ deactivate () {
 deactivate nondestructive
 
 VIRTUAL_ENV='{{ VIRTUAL_ENV_DIR }}'
-if { [ "$OSTYPE" = "cygwin" ] || [ "$OSTYPE" = "msys" ]; } && command -v cygpath > /dev/null 2>&1 ; then
+if { [ "${OSTYPE-}" = "cygwin" ] || [ "${OSTYPE-}" = "msys" ]; } && command -v cygpath > /dev/null 2>&1; then
     VIRTUAL_ENV=$(cygpath -u "$VIRTUAL_ENV")
 fi
 export VIRTUAL_ENV