Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect PAGER environment variable in uv help #4931

Closed
zanieb opened this issue Jul 9, 2024 · 1 comment · Fixed by #5511
Closed

Respect PAGER environment variable in uv help #4931

zanieb opened this issue Jul 9, 2024 · 1 comment · Fixed by #5511
Assignees
@MadGanGithub
Labels
cli Related to the command line interface configuration Settings and such good first issue Good for newcomers

Comments

@zanieb
Copy link
Member

zanieb commented Jul 9, 2024

See #4909 (comment)
@zanieb zanieb added good first issue Good for newcomers configuration Settings and such cli Related to the command line interface labels Jul 9, 2024
@MadGanGithub
Copy link

Hey @zanieb
I would like to work on this issue
Can you assign me?

@krishnan-chandra krishnan-chandra mentioned this issue Jul 27, 2024
Merged
zanieb added a commit that referenced this issue Oct 1, 2024
@krishnan-chandra @zanieb
Respect PAGER env var when paging in uv help command (#5511)
bc459c8 
## Summary

Closes #4931.

## Test Plan

Tried running the following commands locally to make sure that all cases
work:

```
unset PAGER
cargo run -- help venv
```

With no pager set, `uv` correctly finds `less` on the system as it did
before and passes the help output to it.

---

```
PAGER= cargo run -- help venv
```

This correctly prints out to stdout and does not use any pager.

---

```
PAGER=most cargo run -- help venv
```

This correctly opens the `most` pager as shown below:

<img width="1917" alt="Screenshot 2024-07-27 at 5 14 42 PM"
src="https://github.com/user-attachments/assets/dfaa5a83-b47e-4f5c-9be1-b0b1e9818932">

---------

Co-authored-by: Zanie Blue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MadGanGithub MadGanGithub

Labels
cli Related to the command line interface configuration Settings and such good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect PAGER env var when paging in uv help command krishnan-chandra/uv
2 participants
@zanieb @MadGanGithub