Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken path parsing for install spec #6032

Closed
flying-sheep opened this issue Aug 12, 2024 · 10 comments · Fixed by #7767
Closed

Broken path parsing for install spec #6032

flying-sheep opened this issue Aug 12, 2024 · 10 comments · Fixed by #7767
Assignees
Labels
bug Something isn't working

Comments

@flying-sheep
Copy link

$ uv --version
uv 0.2.35
$ uv pip install --editable '/home/phil/Dev/Python/Packaging, Docs/session-info2'
error: Failed to parse: `/home/phil/Dev/Python/Packaging, Docs/session-info2`
  Caused by: Expected path (`/home/phil/Dev/Python/Packaging,`) to end in a supported file extension: `.whl`, `.zip`, `.tar.gz`, `.tar.bz2`, `.tar.xz`, or `.tar.zst`
/home/phil/Dev/Python/Packaging, Docs/session-info2
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@zanieb zanieb added the bug Something isn't working label Aug 12, 2024
@zanieb
Copy link
Member

zanieb commented Aug 12, 2024

Thanks!

cc @charliermarsh might a regression from #5888

@charliermarsh
Copy link
Member

I can take a look.

@charliermarsh charliermarsh self-assigned this Aug 12, 2024
@flying-sheep
Copy link
Author

Ah, sorry, I should have said that there is also an error with older versions before that PR (e.g. 0.2.32)

The underlying issue of something splitting the path at the space is older.

@charliermarsh
Copy link
Member

I think we currently require that you use a backslash here.

@charliermarsh
Copy link
Member

(But of course it should work as-is.)

@flying-sheep
Copy link
Author

I wasn’t aware that escape sequences in dependency specs are a thing at all!

@charliermarsh
Copy link
Member

Yeah it's a bit tricky. Like this doesn't work:

-e /Users/crmarsh/workspace/uv/foo bar/black_editable

But it does work if you quote it, or pass it directly on the command-line etc.

@flying-sheep
Copy link
Author

I am quoting it, see initial comment.

@charliermarsh
Copy link
Member

Yeah I'm describing what the behavior should be, not what we do today.

@flying-sheep
Copy link
Author

I see! Thank you for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants