Cap Requires-Python comparisons at the patch version
#4150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/star
branch
4 times, most recently
from
b2e8705 to
86ccb10
Compare
zanieb
approved these changes
Jun 7, 2024
zanieb
reviewed
Jun 7, 2024
charliermarsh
force-pushed
the
charlie/star
branch
from
86ccb10 to
d08f356
Compare
konstin
reviewed
Jun 10, 2024
| // does not. But, it's debatable. | ||
| // | ||
| // If this scheme proves problematic, we could explore using different semantics when | ||
| // converting to PubGrub. For example, we could parse `>=3.8.*` as `>=3.8,<3.9`. But this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See the long comment inline. I think this is debatable but probably right for now. The other options have their own problems, but there are a few alternate ideas in the comment.
Closes #4132.