Support --link-mode=symlink
#5208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // Try to create a symlink, fallback to copying if it fails. | ||
| if let Err(err) = create_symlink(path, &out_path) { |
There was a problem hiding this comment.
Do you mind adding the whole Attempt::UseCopyFallback thing from hardlink_wheel_files? It's helpful because if we detect that symlinks aren't supported, we basically stop trying.
There was a problem hiding this comment.
Done! Relegated this function to just being a copy of the hardlink function
charliermarsh
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addressing this issue by adding the capability for Symbolic linking as a link mode when installing or syncing dependencies.
Test Plan