Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't drop download error source #6338

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Don't drop download error source #6338

merged 1 commit into from
Aug 21, 2024

Conversation

konstin
Copy link
Member

@konstin konstin commented Aug 21, 2024

Part of #6331

@konstin konstin requested a review from charliermarsh August 21, 2024 15:07
@konstin konstin added the error messages Messaging when something goes wrong label Aug 21, 2024
zanieb
zanieb approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using a miette report here?

@konstin
Copy link
Member Author

konstin commented Aug 21, 2024 •
edited
Loading

As we're it using it elsewhere in uv, miette always discards the error sources, so we couldn't use it here the same way.

@zanieb zanieb merged commit e7fb452 into main Aug 21, 2024
57 checks passed
@zanieb zanieb deleted the konsti/dont-drop-error-source branch August 21, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

@charliermarsh charliermarsh Awaiting requested review from charliermarsh

Assignees
No one assigned
Labels
error messages Messaging when something goes wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konstin @zanieb