Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate nightly build failure with AstroSDK #2167

Closed
utkarsharma2 opened this issue May 31, 2024 · 2 comments
Closed

Investigate nightly build failure with AstroSDK #2167

utkarsharma2 opened this issue May 31, 2024 · 2 comments
Assignees

Comments

@utkarsharma2
Copy link
Collaborator

utkarsharma2 commented May 31, 2024

ref - https://astronomer.slack.com/archives/C059004990C/p1717074355350809
image

@utkarsharma2 utkarsharma2 self-assigned this May 31, 2024
@utkarsharma2
Copy link
Collaborator Author

We build nightlies from the OSS main branch and there was a change done on OSS airflow to update the version from 2.9.0.dev0 to 2.10.0.dev0 in PR .

With the latest 1.8.0 of AstroSDK, we have this version of file astro/sql/operators/raw_sql.py -

import airflow

if airflow.__version__ >= "2.3":
    from sqlalchemy.engine.row import LegacyRow as SQLAlcRow
else:
    from sqlalchemy.engine.result import RowProxy as SQLAlcRow

In the above code snippet, version comparison is not correct, which leads to the ImportError: cannot import name 'RowProxy' from 'sqlalchemy.engine.result' and explains the recent failures:
Screenshot 2024-05-31 at 4 44 36 PM

@utkarsharma2
Copy link
Collaborator Author

Since we no longer have a incorrect version check, which was removed in PR. We can do a release for AstroSDK and it should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant