Test exception catching in test_missing_file #9874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pllim I've tagged you for review since you are a pytest exception/warning catching expert! 😉 |
|
The Matplotlib dev failure is unrelated |
… fact that plt.xlabel and plt.ylabel now pass loc=None by default to set_xlabel and set_ylabel.
pllim
reviewed
Jan 21, 2020
|
Looks uncontroversial enough but I'll wait for the CI to finish before approving. Thanks! |
This was referenced Jan 21, 2020
bsipocz
pushed a commit
that referenced
this pull request
Jan 22, 2020
Test exception catching in test_missing_file
bsipocz
pushed a commit
that referenced
this pull request
Jan 22, 2020
Test exception catching in test_missing_file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this must be due to an update in pytest.
Fixes #9872