-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to verbose=False upon TapPlus instantiation #1722
Comments
I would support this proposal (to default verbose to False at impor time) , but let's ping the gaia folks @jcsegovia for their insight |
(We have the switch to use tap from pyvo on the roadmap, so some behaviour change will definitely happen) |
Just a ping on this, @jcsegovia. Switching the default to |
Please change the default to |
…ation to display AstroQuery's GAIA TAP+ warnings (actually print statements, oops) before load complete acknowledgement. The Gaia warnings issue is a bug at astropy/astroquery#1722 . Note: Order of imports is important here, please keep order in this commit.
👍 I'm also in favor of defaulting to non-verbose. A PR would be welcome. |
@keflavich -- Here is your pull request: #2085 |
Making this change I am a little concerned that there may be instances where verbosity is helpful to verify network connections. I should note the fact that this class instantiates in verbose mode is currently an oversight. It appears that in all other parts of Gaia the verbosity is explicitly set or defaults to False. So adding this change should serve to fulfill the original intent of the code. In reference to changing the default behavior, the Gaia core class also could be modified to accept a setting to change verbosity:
I don't know if there are such mechanisms in Astropy/Astroquery today that would allow implementing either of these solutions. I also don't think it's absolutely necessary. |
…in Gaia class constructor.
Referenced astropy#1722 for changes to default GAIA verbosity (make it run silently on instantiation).
@jpl-jengelke there are configuration mechanisms in place that would allow what you suggest. And, indeed, verbosity can be helpful for diagnosing network issues - but instantiation of the class is probably not the right time to do that. |
Issue #1722: Turn off verbose Tap Plus messages
…in Gaia class constructor.
Referenced astropy#1722 for changes to default GAIA verbosity (make it run silently on instantiation).
…in Gaia class constructor.
Referenced astropy#1722 for changes to default GAIA verbosity (make it run silently on instantiation).
…in Gaia class constructor.
Referenced astropy#1722 for changes to default GAIA verbosity (make it run silently on instantiation).
When instantiating a subclass of the
TapPlus
class (e.g.GaiaClass
), the connection info is printed to stdout:Since
Gaia = GaiaClass
andGaiaClass
is a subclass ofTapPlus
this import statement appears to establish the relevant connections and show them using the defaultverbose=True
forTapPlus
. Since verbose-by-default statements can pollute log files which capture stdout, it would be good to have verbosity turned off by default (either inGaiaClass
orTapPlus
itself). Alternatively, this could be controlled in a config file.I'm happy to make a PR to implement
verbose=False
forTapPlus
but I thought it was enough of a behavior change that it would be good to have a discussion of this first.The text was updated successfully, but these errors were encountered: