Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or catch all warnings raised by the tests #2057

Closed
9 of 11 tasks
bsipocz opened this issue May 5, 2021 · 3 comments
Closed
9 of 11 tasks

Fix or catch all warnings raised by the tests #2057

bsipocz opened this issue May 5, 2021 · 3 comments

Comments

@bsipocz
Copy link
Member

bsipocz commented May 5, 2021

This is an umbrella issue for the warning cleanup, basically the exception list in setup.cfg has to be minimized to the bare minimum by removin the following (after they are either fixed in the codebase or properly catched). Some specific warnings have their own issue to provide smaller starter PR options for new contributors. I would suggest to address this issue gradually during a course of multiple, quicker, smaller PRs rather than one big one that is being around for a longer time:

@pllim
Copy link
Member

pllim commented May 5, 2021

As discussed in #2054, it is okay to blanket ignore all warnings from vo_conesearch.

@bsipocz
Copy link
Member Author

bsipocz commented May 5, 2021

Some of the vo warnings above are indeed coming from vo_conesearch, but roughly half of them originate in other modules while using astropy.io.votable. As opposed to vo_conesearch (which has its days numbered), those should ideally be fixed or properly caught.

@bsipocz
Copy link
Member Author

bsipocz commented Sep 12, 2022

I think #2520 does a big enough dent in this, as well as adds a detailed description to setup.cfg that I'll go ahead and close this issue.

@bsipocz bsipocz closed this as completed Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants