Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magpis, Xmatch documentation cleanup #1952

Merged
merged 4 commits into from
Nov 18, 2022

Conversation

tinuademargaret
Copy link
Contributor

  • Noirlab raises this exception The astroquery.noirlab module module is expecting an older version of the https://astroarchive.noao.edu API services the API is of version 5.0 but the module checks for version 2.0 as the latest version. Would open an issue to correct that.
  • The svo server http://svo2.cab.inta-csic.es/ times out

@bsipocz
Copy link
Member

bsipocz commented Mar 26, 2022

I'm cherry-picking the working changes from here to #2337

@bsipocz bsipocz force-pushed the magpis-others-doc-cleanup branch from befb73f to f5481e7 Compare March 26, 2022 21:55
@bsipocz bsipocz changed the title Magpis, Noirlab, Skyview, Svo_fps, Vamdc, Xmatch documentation cleanup Magpis, Noirlab, Svo_fps, Vamdc, Xmatch documentation cleanup Mar 26, 2022
@bsipocz bsipocz force-pushed the magpis-others-doc-cleanup branch from f5481e7 to f7a3443 Compare November 18, 2022 00:46
@bsipocz bsipocz changed the title Magpis, Noirlab, Svo_fps, Vamdc, Xmatch documentation cleanup Magpis, Xmatch documentation cleanup Nov 18, 2022
@bsipocz bsipocz marked this pull request as ready for review November 18, 2022 00:46
@bsipocz bsipocz added this to the v0.4.7 milestone Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #1952 (f7a3443) into main (0eb8daa) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1952      +/-   ##
==========================================
- Coverage   64.08%   64.06%   -0.02%     
==========================================
  Files         131      131              
  Lines       16927    16911      -16     
==========================================
- Hits        10847    10834      -13     
+ Misses       6080     6077       -3     
Impacted Files Coverage Δ
astroquery/utils/commons.py 75.14% <100.00%> (-1.58%) ⬇️
...roquery/ipac/nexsci/nasa_exoplanet_archive/core.py 57.08% <0.00%> (-0.47%) ⬇️
astroquery/utils/tap/core.py 44.33% <0.00%> (+0.02%) ⬆️
astroquery/mast/auth.py 60.86% <0.00%> (+0.45%) ⬆️
astroquery/utils/cleanup_downloads.py 93.33% <0.00%> (+26.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bsipocz bsipocz merged commit 9bf69d3 into astropy:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants