Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hips2fits documentation cleanup #1974

Merged
merged 2 commits into from
Feb 19, 2022

Conversation

tinuademargaret
Copy link
Contributor

No description provided.

@astropy-bot astropy-bot bot added the hips2fits label Feb 2, 2021
@tinuademargaret tinuademargaret added this to the v0.4.2 milestone Feb 2, 2021
@bsipocz bsipocz modified the milestones: v0.4.2, v0.4.3 May 15, 2021
@bsipocz bsipocz removed this from the v0.4.3 milestone Jul 7, 2021
@bsipocz bsipocz requested a review from ceb8 February 19, 2022 03:46
@bsipocz bsipocz force-pushed the hips2fits-doc-cleanup branch from 13c6b56 to 6236be9 Compare February 19, 2022 04:10
@bsipocz
Copy link
Member

bsipocz commented Feb 19, 2022

OK, this is now rebased to remove the conflict and the lines causing the test run stall are skipped (as they would be otherwise interactive, etc).

@bsipocz
Copy link
Member

bsipocz commented Feb 19, 2022

Locally remote tests pass, so merge away once CI is all green!

@bsipocz bsipocz added this to the v0.4.6 milestone Feb 19, 2022
@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #1974 (6236be9) into main (6400d6c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1974      +/-   ##
==========================================
- Coverage   62.73%   62.72%   -0.01%     
==========================================
  Files         130      130              
  Lines       16842    16847       +5     
==========================================
+ Hits        10565    10568       +3     
- Misses       6277     6279       +2     
Impacted Files Coverage Δ
astroquery/query.py 58.72% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6400d6c...6236be9. Read the comment docs.

@bsipocz bsipocz merged commit a9e3876 into astropy:main Feb 19, 2022
@bsipocz
Copy link
Member

bsipocz commented Feb 19, 2022

Thank you @tinumide!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants