-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Fix vo_conesearch test failures #2059
Conversation
68c9d92
to
56df541
Compare
453ca9d
to
735a2e9
Compare
ffd1212
to
8d61379
Compare
whoops... My patch to monkeypatch isn't backward compatible. |
Codecov Report
@@ Coverage Diff @@
## main #2059 +/- ##
==========================================
- Coverage 67.06% 67.05% -0.02%
==========================================
Files 411 411
Lines 27206 27212 +6
==========================================
+ Hits 18247 18248 +1
- Misses 8959 8964 +5
Continue to review full report at Codecov.
|
These 12 lines took way too much time. 😆 😭 Anyways, tests pass now. |
Thanks @pllim! would you mind opening as issue about the monkeypatch refactor? |
Issue opened at #2063 |
A million thanks @pllim! |
Thank you! |
I am not sure if I am seeing the same failures locally, so I am going to smoke it out in a PR.I think I fixed it. Let's see what CI says. Also see astropy/astropy#10434 . Fix #2054
TODO