Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix vo_conesearch test failures #2059

Merged
merged 2 commits into from
May 5, 2021

Conversation

pllim
Copy link
Member

@pllim pllim commented May 5, 2021

I am not sure if I am seeing the same failures locally, so I am going to smoke it out in a PR.

I think I fixed it. Let's see what CI says. Also see astropy/astropy#10434 . Fix #2054

TODO

  • Drop temporary commit(s).

@pllim pllim force-pushed the fix-vo-conesearch-tests branch 2 times, most recently from 68c9d92 to 56df541 Compare May 5, 2021 19:24
@pllim pllim mentioned this pull request May 5, 2021
@pllim pllim force-pushed the fix-vo-conesearch-tests branch from 453ca9d to 735a2e9 Compare May 5, 2021 19:57
@pllim pllim force-pushed the fix-vo-conesearch-tests branch from ffd1212 to 8d61379 Compare May 5, 2021 21:46
@pllim pllim marked this pull request as ready for review May 5, 2021 21:47
@pllim
Copy link
Member Author

pllim commented May 5, 2021

whoops... My patch to monkeypatch isn't backward compatible.

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #2059 (3b1d8ec) into main (d0ed8c9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2059      +/-   ##
==========================================
- Coverage   67.06%   67.05%   -0.02%     
==========================================
  Files         411      411              
  Lines       27206    27212       +6     
==========================================
+ Hits        18247    18248       +1     
- Misses       8959     8964       +5     
Impacted Files Coverage Δ
astroquery/conftest.py 90.90% <ø> (ø)
astroquery/nasa_exoplanet_archive/core.py 94.53% <100.00%> (ø)
astroquery/utils/commons.py 77.61% <100.00%> (+0.11%) ⬆️
astroquery/utils/tests/test_utils.py 92.98% <100.00%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7940f9...3b1d8ec. Read the comment docs.

@pllim pllim requested review from bsipocz and keflavich May 5, 2021 22:01
@pllim
Copy link
Member Author

pllim commented May 5, 2021

These 12 lines took way too much time. 😆 😭 Anyways, tests pass now.

@bsipocz
Copy link
Member

bsipocz commented May 5, 2021

Thanks @pllim!

would you mind opening as issue about the monkeypatch refactor?

@pllim
Copy link
Member Author

pllim commented May 5, 2021

Issue opened at #2063

@bsipocz
Copy link
Member

bsipocz commented May 5, 2021

A million thanks @pllim!

@bsipocz bsipocz merged commit 5ca7593 into astropy:main May 5, 2021
@bsipocz bsipocz added this to the v0.4.2 milestone May 5, 2021
@pllim pllim deleted the fix-vo-conesearch-tests branch May 6, 2021 01:26
@embray
Copy link
Member

embray commented May 17, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vo_conesearch errors with astropy-dev
3 participants