Turn off default verbosity for TapPlus #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keflavich
approved these changes
Nov 24, 2021
|
Hi @bsipocz, @keflavich, I think there is no problem on doing this, but please let me contact the rest of responsibles for our astroquery modules to make sure this message is not important for them. |
|
Hi @bsipocz, @keflavich, I hace not received any concern, so please go ahead with this pull request. |
|
Thanks @jespinosaar! |
bsipocz
force-pushed
the
tapplus_verbose_off
branch
from
036ea63 to
c1bf201
Compare
Codecov Report
@@ Coverage Diff @@
## main #2228 +/- ##
==========================================
- Coverage 61.91% 61.90% -0.02%
==========================================
Files 129 129
Lines 16310 16310
==========================================
- Hits 10099 10097 -2
- Misses 6211 6213 +2
Continue to review full report at Codecov.
|
|
I'm fixing the RTD issues in a separate PR, so going ahead with the merge here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to close #1722
We had multiple user reports that defaulting to being verbose is not their preference (it was mostly users of the gaia module, see #1722 and linked issues therein).
Now as I review the eJWST module, I run into this again, and while we turned off the default verbosity for gaia, I think it's probably better to change that in TapPlus.
As I read the code, the rest of the tap module has defaults to set False, so I suppose there is nothing controversial about this.
cc @jcsegovia and @jespinosaar