-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PLATO to Catalogs #2279
Add PLATO to Catalogs #2279
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2279 +/- ##
==========================================
- Coverage 62.74% 62.73% -0.01%
==========================================
Files 130 130
Lines 16837 16840 +3
==========================================
+ Hits 10564 10565 +1
- Misses 6273 6275 +2
Continue to review full report at Codecov.
|
Hello @jaymedina! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-02-18 16:27:33 UTC |
8712582
to
c082e22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments only. Please squash commits though.
51f3da8
to
4332bc3
Compare
…test_mast.py, and updated CHANGES.rst, and other documentation and formatting updates
Thanks @jaymedina! |
(I merge as this was already passing before the squash and the current CI issue seems absolutely upstream related) |
Functionality: Following the latest MAST patch, this PR adds PLATO as a query option to
astroquery.mast.Catalogs.query_region
andquery_object
.Documentation:
mast.rst
is updated to reflect new PLATO DR1 availability.Testing:
test_mast_remote.py
is updated with a regression test forPLATO
query.