Additional MAST docs test update #2315
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2315 +/- ##
=======================================
Coverage 62.98% 62.98%
=======================================
Files 131 131
Lines 17067 17067
=======================================
Hits 10749 10749
Misses 6318 6318 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
@bsipocz I think this is done now, except for the failing docs build. Can you take a look at that? It doesn't seem to be related to the MAST documentation, but I could be reading the output wrong. |
|
@bsipocz OK I think this really is ready for merge now. |
| @@ -175,124 +174,6 @@ To get a table of metadata associated with observation or product lists use the | |||
| obs_collection Mission ... HST, HLA, SWIFT, GALEX, Kepler, K2... | |||
|
|
|||
|
|
|||
|
|
|||
| Mission Searches | |||
There was a problem hiding this comment.
One last thing, why did you move this section around? I'm only asking as this will certainly introduce a conflict with another PR once merged (maybe there'll be a conflict in either case).
There was a problem hiding this comment.
Because it was in between the Mast Observations section and the Downloading Data section, which are related because you download data from the observations queries, whereas the Missions interface is completely different and does not yet hook into the download data functionality.
There was a problem hiding this comment.
OK. Let's merge #2321 then first (it's almost there) and then do this reorder.
|
OK, so the other PR is merged, could you please rebase this? That only contained a very small number of changes to the narrative docs, so I expect this to be a trivial conflict resolution. |
|
@bsipocz rebased! |
|
@ceb8 - I've added back the deleted example, as well as the use of the topmost namespace. |
Follow-on to #1975.
@bsipocz I made a mistake last night when re-basing and failed to commit/push my additional changes, so that is what this PR is. Mainly fixing up the Missions MAST docs, but also addressing your comments on the last PR. I realize I've now undone some of your line breaks and other fix ups so I will put those back in.