-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Adding more dev dependency testing #2378
Conversation
I think it would be sufficient though to run the pre-release tests from cron only? The chances are that we may not notice its failure given the constantly failing remote tests job in cron. |
Codecov Report
@@ Coverage Diff @@
## main #2378 +/- ##
=======================================
Coverage 63.29% 63.29%
=======================================
Files 132 132
Lines 17241 17241
=======================================
Hits 10913 10913
Misses 6328 6328 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Re: badge -- AFAIK, you cannot just have badge status for one job of many in a workflow. But you can isolate that job in its own workflow and then generate a badge for that one workflow. 🤷 https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/adding-a-workflow-status-badge |
I also wonder if your workflows could be simplified by using https://github.com/OpenAstronomy/github-actions-workflows but that is probably out of scope here. |
Thanks for the badge reference, I'll have to sleep on the question of how to cut up the workflow (right now thinking of dumping the cron jobs into a separate one, but also separating out the devtesting, so we can have the badge for that one). It's not ideal to then have 3 workflows rather than just one config file, but then it's also not a big deal. |
56d2004
to
0b11785
Compare
OK, so let's go ahead with this as a prototype for what pyvo downstream could do to help the integration testing of pyvo. |
Double checking it looks like that none of the deps is in a RC state, so the pre-release job has to be double checked when e.g. the astropy RC comes out to make sure it's indeed picked up. |
Sounds like a plan. Thanks! |
The main motivation here is to provide downstream testing for pyvo during their dev cycle