Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding warning about non-functioning NRAO module #2387

Merged
merged 2 commits into from
May 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions astroquery/nrao/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@
"""
from astropy import config as _config

import warnings

# Remove module altogether if API update is not done in 6 months (2022-11-02).
warnings.warn("The legacy NRAO archive this module uses has been retired causing astroquery.nrao to be "
"broken. We will remove this exception once sufficient updates are done to use the new "
"NRAO archive API.")


class Conf(_config.ConfigNamespace):
"""
Expand Down
1 change: 0 additions & 1 deletion astroquery/nrao/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

from io import BytesIO

import numpy as np
import astropy.units as u
import astropy.io.votable as votable
from astropy import coordinates
Expand Down
4 changes: 4 additions & 0 deletions astroquery/nrao/tests/test_nrao.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
import astropy.units as u
from astropy.table import Table

# Skip tests in this file until the new API is implemented:
# https://github.com/astropy/astroquery/issues/2316
pytest.skip(allow_module_level=True)

from ... import nrao
from astroquery.utils.mocks import MockResponse
from ...utils import commons
Expand Down
4 changes: 4 additions & 0 deletions astroquery/nrao/tests/test_nrao_remote.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
from astropy.table import Table
from astropy import units as u

# Skip tests in this file until the new API is implemented:
# https://github.com/astropy/astroquery/issues/2316
pytest.skip(allow_module_level=True)

from astroquery.utils.commons import ASTROPY_LT_4_1
from ... import nrao

Expand Down
4 changes: 4 additions & 0 deletions docs/nrao/nrao.rst
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
.. doctest-skip-all
.. # Skip tests in this file until the new API is implemented:
.. # https://github.com/astropy/astroquery/issues/2316

.. _astroquery.nrao:

********************************
Expand Down