Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Fix incomplete URLs in regrex #2394

Merged
merged 1 commit into from
May 5, 2022
Merged

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented May 5, 2022

These were picked up by codeQL as potential risks.

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #2394 (6358629) into main (96f63eb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2394   +/-   ##
=======================================
  Coverage   62.87%   62.87%           
=======================================
  Files         133      133           
  Lines       17246    17246           
=======================================
  Hits        10844    10844           
  Misses       6402     6402           
Impacted Files Coverage Δ
astroquery/eso/core.py 29.09% <ø> (ø)
astroquery/fermi/core.py 89.23% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bsipocz
Copy link
Member Author

bsipocz commented May 5, 2022

I'm not sure why these started to cause CI failures recently, nevertheless this fix seems to be enough to get rid of that failure, so I go ahead and merge it now.

@bsipocz bsipocz merged commit f20c85b into astropy:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant