Remove deprecated NASA Exoplanet Archive code #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removed code was deprecated in v0.4.1 almost two years ago.
Codecov Report
@@ Coverage Diff @@
## main #2431 +/- ##
==========================================
- Coverage 62.97% 62.92% -0.05%
==========================================
Files 133 133
Lines 17290 17271 -19
==========================================
- Hits 10888 10868 -20
- Misses 6402 6403 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
rickynilsson
approved these changes
Jun 2, 2022
bsipocz
approved these changes
Jun 2, 2022
There was a problem hiding this comment.
Super nitpick (that I'll fix in release): you need to add the PR number in the changelog.
Very handy small script to get it before opening a PR (so to avoid rerunning the CI for the changelog): https://github.com/astropy/astropy-tools/blob/main/next_pr_number.py
|
Thanks @eerovaher! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed code was deprecated by #1700 in v0.4.1 almost two years ago.