Perform unit conversion in svo_fps get_filter_index()
#2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the remote tests requested data for all possible wavelength values, unsurprisingly causing a timeout.
`SvoFpsClass.get_filter_index()` assumes that the wavelength limits are in angstroms. This leads to unexpected results if different units are used, as revealed by the modified test.
`SvoFpsClass.get_filter_index()` now accepts the wavelength limits in any length unit, not just in angstroms.
Codecov Report
@@ Coverage Diff @@
## main #2444 +/- ##
=======================================
Coverage 62.90% 62.90%
=======================================
Files 133 133
Lines 17291 17291
=======================================
Hits 10877 10877
Misses 6414 6414
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
bsipocz
approved these changes
Jun 17, 2022
|
Thanks @eerovaher! As you have dug a bit into this module already, would you have any time or energy to fix the other remote failure about the missing error? Then we could tick this module out from #2203. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SvoFpsClass.get_filter_index()method allows the user to specify wavelength limits. Previously the code assumed that they are always given in angstroms. Now the code converts them to angstroms, allowing the user to specify the wavelengths using any length unit and leading to an early unit conversion error if the limits do not have length units.Fixes #2443