Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting API key for astroquery.astrometry_net #2459

Merged
merged 2 commits into from
Jul 9, 2022

Conversation

moemyself3
Copy link
Contributor

Update docs to include part of one section intended by original author.

Update docs to include part of one section intended by original author.
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #2459 (2092aab) into main (26618d1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2459   +/-   ##
=======================================
  Coverage   62.92%   62.92%           
=======================================
  Files         133      133           
  Lines       17300    17300           
=======================================
  Hits        10886    10886           
  Misses       6414     6414           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

4. Add your API key to the config file!

For more information about `astropy.config`, see: https://docs.astropy.org/en/stable/config/index.html

TODO: explain how to set config item for api key or how to get it into keyring.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tihnk you can remove this TODO with the edits you put in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had not removed the TODO since they also wanted to include instructions using keyring. I learned to use keyring and will write a simple example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed TODO and added keyring example with commit 2092aab

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we don't yet remote-test this file, this looks good as is. Thanks!

@bsipocz bsipocz merged commit e99cf10 into astropy:main Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants