Refactored query criteria to use ehst.archive table #2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2524 +/- ##
=======================================
Coverage 63.08% 63.08%
=======================================
Files 133 133
Lines 17313 17313
=======================================
Hits 10922 10922
Misses 6391 6391
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
keflavich
approved these changes
Sep 12, 2022
bsipocz
requested changes
Sep 12, 2022
There was a problem hiding this comment.
One minor thing with the changelog that I'm happy to fix myself prior merging.
However, I now see a relevant doctest failure in docs/esa/hubble/hubble.rst (it maybe just the one it first stopped), please go through those as part of this PR.
python setup.py test -t docs/esa/hubble --remote-data
bsipocz
approved these changes
Sep 13, 2022
|
Thanks @javier-ballester! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Astroquery team,
The query_criteria method in Hubble astroquery is using a complex query, joining three big tables and this makes its execution really slow. This query has been refactored to use only ehst.archive table, which contains all the criteria parameters.
Please let me know if any further changes are necessary.
Kind regards,
Javier