ENH: get_query_payload to return useful info #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This functionality is very much has debug purposes only, so I don't think we need to have this listed in the changelog. |
Codecov Report
@@ Coverage Diff @@
## main #2585 +/- ##
=======================================
Coverage 64.08% 64.08%
=======================================
Files 131 131
Lines 16927 16927
=======================================
Hits 10847 10847
Misses 6080 6080
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
keflavich
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The naming of the kwarg is somewhat misleading, we should aim it to return the payload that is in fact sent out to the server, not an intermediate one in our library yet to be processed further. So in this case the adql query string is more useful than a payload dictionary yet to be process to generate the query string.