BUG: nasa_exoplanet_archive get_query_payload to return actual query #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2588 +/- ##
==========================================
- Coverage 64.08% 64.07% -0.01%
==========================================
Files 131 131
Lines 16927 16929 +2
==========================================
Hits 10847 10847
- Misses 6080 6082 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rickynilsson
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to close #2129
The logic is very similar to #2585 (and also detailed in the issue). With this PR all modules that have get_query_payload kwarg seem to return the SQL query when available, or the payload dict if it's passed directly into a GET/POST request.