Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPC: Add star catalog column #2957

Merged
merged 4 commits into from
Apr 6, 2024
Merged

MPC: Add star catalog column #2957

merged 4 commits into from
Apr 6, 2024

Conversation

tristandijkstra
Copy link
Contributor

Hello,

The MPC 80-column format used by astroquery's MPC.get_observations() contains a column (col 72) that gives the star catalog used for the observation which is currently not implemented/exposed. This is a simple PR to add that column toMPC.get_observations().

Here is some info on that column: https://www.minorplanetcenter.net/iau/info/CatalogueCodes.html

@pep8speaks
Copy link

pep8speaks commented Feb 26, 2024

Hello @tristandijkstra! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-04-06 03:07:39 UTC

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.81%. Comparing base (a20e431) to head (9fc602e).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2957   +/-   ##
=======================================
  Coverage   66.81%   66.81%           
=======================================
  Files         237      237           
  Lines       18319    18319           
=======================================
  Hits        12239    12239           
  Misses       6080     6080           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsipocz bsipocz added the mpc label Feb 27, 2024
@tristandijkstra
Copy link
Contributor Author

Hi @bsipocz,

I have updated the PR and tried again but the build still fails. From the log, it appears that the read-the-docs build is failing due to 4 warnings from the ALMA and IRSA services:

/home/docs/checkouts/readthedocs.org/user_builds/astroquery/envs/2957/lib/python3.10/site-packages/astroquery/alma/core.py:docstring of astroquery.alma.core.AlmaClass.query_sia:25: WARNING: py:obj reference target not found: pyvo.dam.obscore.POLARIZATION_STATES
/home/docs/checkouts/readthedocs.org/user_builds/astroquery/envs/2957/lib/python3.10/site-packages/astroquery/alma/core.py:docstring of astroquery.alma.core.AlmaClass.query_sia:66: WARNING: py:obj reference target not found: pyvo.dam.obscore.CALIBRATION_LEVELS
/home/docs/checkouts/readthedocs.org/user_builds/astroquery/envs/2957/lib/python3.10/site-packages/astroquery/ipac/irsa/core.py:docstring of astroquery.ipac.irsa.core.IrsaClass.query_sia:25: WARNING: py:obj reference target not found: pyvo.dam.obscore.POLARIZATION_STATES
/home/docs/checkouts/readthedocs.org/user_builds/astroquery/envs/2957/lib/python3.10/site-packages/astroquery/ipac/irsa/core.py:docstring of astroquery.ipac.irsa.core.IrsaClass.query_sia:66: WARNING: py:obj reference target not found: pyvo.dam.obscore.CALIBRATION_LEVELS
generating indices... genindex py-modindex done

Please let me know if there's anything else I can do.

@bsipocz bsipocz added this to the v0.4.8 milestone Apr 6, 2024
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thank you @tristandijkstra!

I'll do a rebase before merging to get rid of the merge commit, and to get a fully green CI.

@bsipocz bsipocz merged commit 5f54ec6 into astropy:main Apr 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants