-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GAIA: Due to the new tap 9.8.0, functions return uncompressed FITS/ECSV files #2983
GAIA: Due to the new tap 9.8.0, functions return uncompressed FITS/ECSV files #2983
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2983 +/- ##
==========================================
- Coverage 66.83% 66.82% -0.01%
==========================================
Files 237 237
Lines 18327 18324 -3
==========================================
- Hits 12248 12245 -3
Misses 6079 6079 ☔ View full report in Codecov by Sentry. |
I suspect the oldest version CI failure will go away once #2966 is merged, so I would hold up merging this until then (that PR should go in early next week). |
…essed since from tap 9.8.0 only format votable_gzip returns a gzipped file.
…essed since from tap 9.8.0 only format votable_gzip returns a gzipped file.
… changed done in the default value of the parameter format in the function load_data
8084c7d
to
6599113
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rebased to pick up the changes to the CI, and those indeed fixed the failures.
Thanks!
Also, @cosmoJFH if you add the email address you make these commits to your github profile they will properly show up as yours.
Due to the latest changes in the TAP library (version 0.9.8) used in the Gaia Archive, for the functions that return files in FITS/ECSV format, these files are now provided as uncompressed files.
cc @esdc-esac-esa-int
jira: GAIAPCR-1317