Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPL Horizons: Test refraction with and extra_precision #2986

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

mkelley
Copy link
Contributor

@mkelley mkelley commented Apr 9, 2024

Added column definitions to address #2977 . In addition, reviewed other possible column return values and added
a few that may be missing (see https://ssd.jpl.nasa.gov/horizons/manual.html#output ).

@pep8speaks
Copy link

pep8speaks commented Apr 9, 2024

Hello @mkelley! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-04-09 14:28:24 UTC

@mkelley mkelley changed the title JPL Horizons: Test refraction=True and extra_precision=True JPL Horizons: Test refraction with and extra_precision Apr 9, 2024
@bsipocz bsipocz added this to the v0.4.8 milestone Apr 9, 2024
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mkelley!

@bsipocz bsipocz merged commit 8e7c6af into astropy:main Apr 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants