EHSTPCR-1144: Implemented the function get_datalabs_path along with the #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @esdc-esac-esa-int! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-04-29 09:20:54 UTC |
added 2 commits
April 25, 2024 17:37
|
Build problem with docs/readthedocs.org:astroquery, but this problem seems unrelated to this ticket |
jespinosaar
reviewed
Apr 26, 2024
CHANGES.rst
Outdated
| @@ -193,6 +193,10 @@ esa.hubble | |||
| - New methods to retrieve metadata (``get_observations_from_program``) and | |||
| files (``download_files_from_program``) associated to a proposal. [#2910] | |||
|
|
|||
| - New method ``get_datalabs_path``to return the complete path of a file in | |||
| datalambs by combining the datalabs volume path with the path of the file | |||
There was a problem hiding this comment.
Please fix the typo here (datalambs)
There was a problem hiding this comment.
Typo fixed
added 3 commits
April 26, 2024 10:08
conform to the defaults in datalabs. Default value for default_volume is now None, and in that case the volume and the first folders of the path are filled automatically
|
Fixed the code style issues |
|
Added /filename to the output of the function to get the complete path to the file |
of default_volume=None
|
@talonsoalbi - if you add the email address you made the commits with to your github profile, these commits will properly show up as your contributions. |
|
Many thanks @bsipocz !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a function get_datalabs_path to return the complete path of a file in datalabs by combining the datalabs volume path with the path of the file in the table ehst.artifact