Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EHSTPCR-1144: Implemented the function get_datalabs_path along with the #2998

Merged
merged 8 commits into from
May 3, 2024
Merged

EHSTPCR-1144: Implemented the function get_datalabs_path along with the #2998

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ddd52cb
EHSTPCR-1144: Implemented the function get_datalabs_path along with the
Apr 25, 2024
e235ddc
EHSTPCR-1144: code style fixes
Apr 25, 2024
1fb9ef4
EHSTPCR-1144: fixed a style error, and added the changes in this branch
Apr 25, 2024
61d2473
EHSTPCR-1144: fixed a type in CHANGES.rst
Apr 26, 2024
199ce3f
EHSTPCR-1144: fix the path returned in get_datalabs_path to make it
Apr 26, 2024
a80117f
EHSTPCR-1144: code style fixes
Apr 26, 2024
e15f935
EHSTPCR-1144: add /<filename> at the end for the complete path
Apr 29, 2024
8ef110a
EHSTPCR-1144: fix the path, variable path was added incorrectly in case
Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,10 @@ esa.hubble
- New methods to retrieve metadata (``get_observations_from_program``) and
files (``download_files_from_program``) associated to a proposal. [#2910]

- New method ``get_datalabs_path``to return the complete path of a file in
datalambs by combining the datalabs volume path with the path of the file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the typo here (datalambs)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fixed

in the table ehst.artifact [#2998]

esa.jwst
^^^^^^^^

Expand Down
1 change: 1 addition & 0 deletions astroquery/esa/hubble/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,4 +1025,5 @@ def get_datalabs_path(self, filename, default_volume=''):

return default_volume + self._get_decoded_string(string=job["file_path"][0])


ESAHubble = ESAHubbleClass()
Loading