Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESASky handle eROSITA downloads #3111

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

emellega
Copy link
Contributor

@emellega emellega commented Oct 1, 2024

No description provided.

@pep8speaks
Copy link

pep8speaks commented Oct 1, 2024

Hello @emellega! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-10-01 18:58:12 UTC

@emellega emellega force-pushed the esasky-support-erosita-downloads branch from 7b1bfcb to fc7737d Compare October 1, 2024 11:47
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 67.36%. Comparing base (6959406) to head (ba9350a).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/esasky/core.py 9.09% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3111      +/-   ##
==========================================
- Coverage   67.39%   67.36%   -0.04%     
==========================================
  Files         233      233              
  Lines       18405    18415      +10     
==========================================
+ Hits        12404    12405       +1     
- Misses       6001     6010       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emellega emellega force-pushed the esasky-support-erosita-downloads branch from fc7737d to ba9350a Compare October 1, 2024 11:55
@imbasimba
Copy link
Contributor

Thanks, Erik! This looks good to me :)

@bsipocz bsipocz added the esasky label Oct 1, 2024
@bsipocz bsipocz added this to the v0.4.8 milestone Oct 1, 2024
@bsipocz
Copy link
Member

bsipocz commented Oct 1, 2024

Thank you @emellega! I'll quickly add a changelog entry and go ahead with the merge.

@bsipocz bsipocz force-pushed the esasky-support-erosita-downloads branch from 94b93fe to 7ac1836 Compare October 1, 2024 18:58
@bsipocz bsipocz merged commit 88b6409 into astropy:main Oct 1, 2024
1 check was pending
@emellega emellega deleted the esasky-support-erosita-downloads branch October 4, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants