[XMatch] fix: upload of two local tables is now possible #3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3116 +/- ##
==========================================
+ Coverage 67.36% 67.38% +0.02%
==========================================
Files 233 233
Lines 18415 18417 +2
==========================================
+ Hits 12405 12411 +6
+ Misses 6010 6006 -4 ☔ View full report in Codecov by Sentry. |
ManonMarchand
changed the title
bsipocz
approved these changes
Oct 4, 2024
| fp = StringIO() | ||
| cat.write(fp, format='ascii.csv') | ||
| fp.seek(0) | ||
| kwargs['files'].update({catstr: (f'cat{cat_index}.csv', fp.read())}) |
There was a problem hiding this comment.
I suppose you don't have to regenerate cat{cat_index} here, but reuse it from L127 as f'{catstr}', however this is a ridiculous level of nitpicking, so I'll just go ahead and merge the fix instead :)
There was a problem hiding this comment.
Oh, yes it was better than what I did. Don't hesitate to change something if it happens again in an other PR, I won't be offended 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello astroquery 🙂
In the files dictionary sent to XMatch, the second table was written over the first one, resulting in a confusing "missing cat1" error even if the user did give a cat1. This fixes #3115 , closes #1687 and closes #1786
I did not add a remote test, only a local one. Is it ok?