Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start writing tests... #7

Merged
merged 18 commits into from
Aug 4, 2018
Merged

Start writing tests... #7

merged 18 commits into from
Aug 4, 2018

Conversation

mwcraig
Copy link
Member

@mwcraig mwcraig commented Aug 1, 2018

...right now these mostly fail, will work on in the morning.

There is one problem I'm hitting @pllim -- when I try python setup.py test locally I get an error when tests are being collected; any idea what the cause might be? In the meantime I'm running them with python setup.py test --args '--continue-on-collection-errors'

============================================================ ERRORS =============================================================
_____________________________________________ ERROR collecting astrowidgets/core.py _____________________________________________
/Users/mcraig/conda-main/envs/awid-dev/lib/python3.6/site-packages/pytest_doctestplus/plugin.py:95: in collect
    for test in finder.find(module):
/Users/mcraig/conda-main/envs/awid-dev/lib/python3.6/site-packages/pytest_doctestplus/plugin.py:340: in find
    extraglobs)
/Users/mcraig/conda-main/envs/awid-dev/lib/python3.6/doctest.py:933: in find
    self._find(tests, obj, name, module, source_lines, globs, {})
/Users/mcraig/conda-main/envs/awid-dev/lib/python3.6/doctest.py:992: in _find
    if ((inspect.isroutine(inspect.unwrap(val))
/Users/mcraig/conda-main/envs/awid-dev/lib/python3.6/inspect.py:512: in unwrap
    while _is_wrapper(func):
/Users/mcraig/conda-main/envs/awid-dev/lib/python3.6/inspect.py:503: in _is_wrapper
    return hasattr(f, '__wrapped__')
/Users/mcraig/conda-main/envs/awid-dev/lib/python3.6/site-packages/ginga/misc/Bunch.py:211: in __getattr__
    return self.tbl[attr]
/Users/mcraig/conda-main/envs/awid-dev/lib/python3.6/site-packages/ginga/misc/Bunch.py:96: in __getitem__
    return self.dict[k][1]
E   KeyError: '__wrapped__'
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
==================================================== 1 error in 0.43 seconds ====================================================

@mwcraig mwcraig changed the title Start writing tests... [WIP] Start writing tests... Aug 1, 2018
@pllim
Copy link
Member

pllim commented Aug 1, 2018

@mwcraig , do we need doctestplus on ImageWidget tests? It appears incompatible with Ginga's Bunch object, which duck-type dict but only to some extend.



def test_load_fits():
image = ImageWidget()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion is to make these functions into a test class' methods. That way, you can initialize image = ImageWidget() only once at setup_class() and then use the same object throughout.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable; I'm going to keep implementing as functions for the moment so we can see whether there are any tests where we want separate ImageWidget instances.

For example, it looks like setting cuts with a string fails in a way users will find surprising if the data hasn't been set yet. In that case the cuts are set to (0, 0) (which makes sense) but that is probably not what the user wants; to test for this I think we want a new ImageWidget without data for that test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I should have read this before commenting on #8

@mwcraig
Copy link
Member Author

mwcraig commented Aug 1, 2018

@mwcraig , do we need doctestplus on ImageWidget tests? It appears incompatible with Ginga's Bunch object, which duck-type dict but only to some extend.

No, probably not; I just tried setting doctest_plus = disabled but still got the same error, though...

@pllim
Copy link
Member

pllim commented Aug 1, 2018

@drdavella , any advice on how to get rid of the doctest_plus error? Thanks.

@drdavella
Copy link

It's possibly due to some regressions introduced in pytest 3.7, but it's hard for me to tell without the full test report.

@pllim
Copy link
Member

pllim commented Aug 1, 2018

In that case, does the error go away if you use pytest <= 3.6, @mwcraig ? Thanks, Dan!

@mwcraig mwcraig changed the title [WIP] Start writing tests... Start writing tests... Aug 2, 2018
@mwcraig
Copy link
Member Author

mwcraig commented Aug 2, 2018

All of the tests currently pass 😀 so read to merge....

@mwcraig
Copy link
Member Author

mwcraig commented Aug 2, 2018

Unfortunately I'm using pytest 3.6.4 😢

I'll take another look in the morning...

@drdavella
Copy link

If you want to post the full log here I can take a look and see if anything obvious stands out.

@pllim
Copy link
Member

pllim commented Aug 2, 2018

@mwcraig , now I am confused. Is the pytest failure still a problem or not?

@mwcraig
Copy link
Member Author

mwcraig commented Aug 2, 2018

Yep, pytest failure is still a problem if doctest_plus is enabled. Full output from pytest is below. The main thing I don't understand is why pytest is digging down so deep into package dependencies to look for docstrings to test.

~/D/astrowidgets (make-tests-work) $ python setup.py test                                                             (awid-dev)
git submodule command failed unexpectedly:
error: pathspec 'astropy_helpers' did not match any file(s) known to git.
Downloading 'astropy-helpers'; run setup.py with the --offline option to force offline installation.
/Users/mcraig/conda-main/envs/awid-dev/lib/python3.6/site-packages/setuptools/dist.py:398: UserWarning: Normalizing '0.0.dev031' to '0.0.dev31'
  normalized_version,
running test
Searching for opencv-python
Best match: opencv-python 3.4.2.17
Processing opencv_python-3.4.2.17-py3.6-macosx-10.7-x86_64.egg

Using /Users/mcraig/Development/astrowidgets/.eggs/opencv_python-3.4.2.17-py3.6-macosx-10.7-x86_64.egg
running install
running build
running build_py
running install_lib
creating /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib
creating /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6
creating /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages
creating /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets
copying build/lib/astrowidgets/conftest.py -> /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets
copying build/lib/astrowidgets/version.py -> /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets
copying build/lib/astrowidgets/example_mod.py -> /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets
copying build/lib/astrowidgets/_astropy_init.py -> /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets
creating /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/tests
copying build/lib/astrowidgets/tests/__init__.py -> /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/tests
copying build/lib/astrowidgets/tests/coveragerc -> /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/tests
copying build/lib/astrowidgets/tests/test_api.py -> /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/tests
copying build/lib/astrowidgets/tests/setup_package.py -> /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/tests
copying build/lib/astrowidgets/__init__.py -> /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets
copying build/lib/astrowidgets/core.py -> /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets
creating /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/utils
creating /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/utils/tests
copying build/lib/astrowidgets/utils/tests/__init__.py -> /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/utils/tests
copying build/lib/astrowidgets/utils/__init__.py -> /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/utils
creating /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/extern
copying build/lib/astrowidgets/extern/__init__.py -> /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/extern
creating /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/data
copying build/lib/astrowidgets/data/README.rst -> /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/data
creating /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/example_subpkg
creating /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/example_subpkg/tests
copying build/lib/astrowidgets/example_subpkg/tests/__init__.py -> /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/example_subpkg/tests
copying build/lib/astrowidgets/example_subpkg/__init__.py -> /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/example_subpkg
copying build/lib/astrowidgets/example_subpkg/setup_package.py -> /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/example_subpkg
byte-compiling /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/conftest.py to conftest.cpython-36.pyc
byte-compiling /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/version.py to version.cpython-36.pyc
byte-compiling /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/example_mod.py to example_mod.cpython-36.pyc
byte-compiling /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/_astropy_init.py to _astropy_init.cpython-36.pyc
byte-compiling /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/tests/__init__.py to __init__.cpython-36.pyc
byte-compiling /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/tests/test_api.py to test_api.cpython-36.pyc
byte-compiling /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/tests/setup_package.py to setup_package.cpython-36.pyc
byte-compiling /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/__init__.py to __init__.cpython-36.pyc
byte-compiling /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/core.py to core.cpython-36.pyc
byte-compiling /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/utils/tests/__init__.py to __init__.cpython-36.pyc
byte-compiling /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/utils/__init__.py to __init__.cpython-36.pyc
byte-compiling /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/extern/__init__.py to __init__.cpython-36.pyc
byte-compiling /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/example_subpkg/tests/__init__.py to __init__.cpython-36.pyc
byte-compiling /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/example_subpkg/__init__.py to __init__.cpython-36.pyc
byte-compiling /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets/example_subpkg/setup_package.py to setup_package.cpython-36.pyc
running install_egg_info
running egg_info
writing astrowidgets.egg-info/PKG-INFO
writing dependency_links to astrowidgets.egg-info/dependency_links.txt
writing entry points to astrowidgets.egg-info/entry_points.txt
writing requirements to astrowidgets.egg-info/requires.txt
writing top-level names to astrowidgets.egg-info/top_level.txt
reading manifest file 'astrowidgets.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching 'CHANGES.rst'
warning: no files found matching '*.pyx' under directory 'astrowidgets'
warning: no files found matching '*.c' under directory 'astrowidgets'
warning: no files found matching '*.pxd' under directory 'astrowidgets'
warning: no files found matching '*' under directory 'cextern'
warning: no files found matching '*' under directory 'scripts'
no previously-included directories found matching 'build'
no previously-included directories found matching 'docs/_build'
no previously-included directories found matching 'docs/api'
warning: no files found matching 'astropy_helpers/README.rst'
warning: no files found matching 'astropy_helpers/CHANGES.rst'
warning: no files found matching 'astropy_helpers/LICENSE.rst'
warning: no files found matching '*' under directory 'astropy_helpers/licenses'
warning: no files found matching 'astropy_helpers/ah_bootstrap.py'
warning: no files found matching '*.py' under directory 'astropy_helpers/astropy_helpers'
warning: no files found matching '*.pyx' under directory 'astropy_helpers/astropy_helpers'
warning: no files found matching '*.c' under directory 'astropy_helpers/astropy_helpers'
warning: no files found matching '*.h' under directory 'astropy_helpers/astropy_helpers'
warning: no files found matching '*.rst' under directory 'astropy_helpers/astropy_helpers'
warning: no files found matching '*' under directory 'astropy_helpers/astropy_helpers.egg-info'
warning: no files found matching '*' under directory 'astropy_helpers/astropy_helpers/sphinx'
no previously-included directories found matching 'astropy_helpers/build'
no previously-included directories found matching 'astropy_helpers/astropy_helpers/tests'
warning: no previously-included files matching '*.pyc' found anywhere in distribution
warning: no previously-included files matching '*.o' found anywhere in distribution
writing manifest file 'astrowidgets.egg-info/SOURCES.txt'
Copying astrowidgets.egg-info to /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages/astrowidgets-0.0.dev31-py3.6.egg-info
running install_scripts
Installing astropy-package-template-example script to /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/bin
====================================================== test session starts ======================================================
platform darwin -- Python 3.6.6, pytest-3.6.4, py-1.5.4, pluggy-0.6.0

Running tests with Astropy version 3.0.3.
Running tests in astrowidgets.

Date: 2018-08-02T10:42:11

Platform: Darwin-17.7.0-x86_64-i386-64bit

Executable: /Users/mcraig/conda-main/envs/awid-dev/bin/python

Full Python Version:
3.6.6 |Anaconda, Inc.| (default, Jun 28 2018, 11:07:29)
[GCC 4.2.1 Compatible Clang 4.0.1 (tags/RELEASE_401/final)]

encodings: sys: utf-8, locale: UTF-8, filesystem: utf-8
byteorder: little
float info: dig: 15, mant_dig: 15

Numpy: 1.15.0
Scipy: 1.1.0
Matplotlib: 2.2.2
h5py: not available
Pandas: not available
astropy_helpers: 3.0.2
Using Astropy options: remote_data: none.

rootdir: /private/var/folders/j2/kwz9qs3d54j3p5mv5m9m5mz44_blx6/T/astrowidgets-test-e8er0z5j/lib/python3.6/site-packages, inifile: setup.cfg
plugins: remotedata-0.3.0, openfiles-0.3.0, doctestplus-0.1.3, arraydiff-0.2
collected 20 items / 1 errors

============================================================ ERRORS =============================================================
_____________________________________________ ERROR collecting astrowidgets/core.py _____________________________________________
/Users/mcraig/conda-main/envs/awid-dev/lib/python3.6/site-packages/pytest_doctestplus/plugin.py:95: in collect
    for test in finder.find(module):
/Users/mcraig/conda-main/envs/awid-dev/lib/python3.6/site-packages/pytest_doctestplus/plugin.py:340: in find
    extraglobs)
/Users/mcraig/conda-main/envs/awid-dev/lib/python3.6/doctest.py:933: in find
    self._find(tests, obj, name, module, source_lines, globs, {})
/Users/mcraig/conda-main/envs/awid-dev/lib/python3.6/doctest.py:992: in _find
    if ((inspect.isroutine(inspect.unwrap(val))
/Users/mcraig/conda-main/envs/awid-dev/lib/python3.6/inspect.py:512: in unwrap
    while _is_wrapper(func):
/Users/mcraig/conda-main/envs/awid-dev/lib/python3.6/inspect.py:503: in _is_wrapper
    return hasattr(f, '__wrapped__')
/Users/mcraig/conda-main/envs/awid-dev/lib/python3.6/site-packages/ginga/misc/Bunch.py:211: in __getattr__
    return self.tbl[attr]
/Users/mcraig/conda-main/envs/awid-dev/lib/python3.6/site-packages/ginga/misc/Bunch.py:96: in __getitem__
    return self.dict[k][1]
E   KeyError: '__wrapped__'
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
==================================================== 1 error in 0.41 seconds ====================================================

@mwcraig
Copy link
Member Author

mwcraig commented Aug 2, 2018

If I disable doctest_plus (by removing it from setup.cfg) the tests run successfully, so that's what I'll do later today, I think, unless we find a better fix before that...

@pllim pllim mentioned this pull request Aug 2, 2018
@pllim
Copy link
Member

pllim commented Aug 2, 2018

The only thing that doctest would try to run is this in the docstring:

            from ginga.misc.log import get_logger
            logger = get_logger('my_viewer', log_stderr=False,
                                log_file='ginga.log', level=40)

Even then, I am not sure why it is choking on ginga.misc.Bunch, which is not directly mentioned anywhere. 🤷‍♀️

@pllim
Copy link
Member

pllim commented Aug 2, 2018

@mwcraig , 👍 to disabling doctest for now. Figuring out how to make it work, if needed, can be a separate issue.

@pllim
Copy link
Member

pllim commented Aug 2, 2018

@mwcraig , I activated https://travis-ci.org/astropy/astrowidgets . FYI

@mwcraig
Copy link
Member Author

mwcraig commented Aug 3, 2018

🎉 triggered the first build on travis! 🎈

@pllim
Copy link
Member

pllim commented Aug 4, 2018

The Sphinx failure is because astropy_helpers you are using is missing patch from astropy/astropy-helpers#368 . I recommend changing the submodule here to point to its current master and copy over a compatible ah_bootstrap.py file accordingly.

@pllim
Copy link
Member

pllim commented Aug 4, 2018

Or maybe missing dependencies for Sphinx... 🤔 (nope, adding sphinx-astropy as dependency didn't help)

@mwcraig
Copy link
Member Author

mwcraig commented Aug 4, 2018

Is there any reason not to use conda-forge in the tests? That would pick up ipyevents as a conda package...

@mwcraig
Copy link
Member Author

mwcraig commented Aug 4, 2018

I think I fixed the helpers problem....I had added it as astropy-helpers not astropy_helpers. Second time in a month I've lost time to a _ vs - issue 🙄

@pllim
Copy link
Member

pllim commented Aug 4, 2018

Recent discussions suggested that conda is slower than pip. Otherwise I don't think any reason it won't work.

@mwcraig
Copy link
Member Author

mwcraig commented Aug 4, 2018

Yeah, the conda solver has become really slow....

@pllim
Copy link
Member

pllim commented Aug 4, 2018

It passed! 🎉

@mwcraig
Copy link
Member Author

mwcraig commented Aug 4, 2018

Do you want me to squash before merging?

@pllim
Copy link
Member

pllim commented Aug 4, 2018

I think @eteq and I have differing opinions on the topic of squashing... But I say yes. ;)

@mwcraig mwcraig merged commit 54e4589 into astropy:master Aug 4, 2018
@mwcraig
Copy link
Member Author

mwcraig commented Aug 4, 2018

I let GitHub do its squash and merge magic....

@mwcraig mwcraig deleted the make-tests-work branch August 5, 2018 02:31
@pllim pllim mentioned this pull request Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants