fix(app-rfi): remove timeout for testing. add prop definition. lintin…

…g fixes
ASU · Oct 4, 2024 · ad7bd44 · ad7bd44
1 parent 39ece80
commit ad7bd44
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 12 deletions.
diff --git a/packages/app-rfi/src/components/stepper/RfiStepperButtons.js b/packages/app-rfi/src/components/stepper/RfiStepperButtons.js
@@ -2,6 +2,7 @@
 import PropTypes from "prop-types";
 import React from "react";
 import { Button } from "reactstrap";
+
 import { trackGAEvent } from "../../../../../shared";
 // Note on the spans around the FA i tags below:
 // When the host site/app deploys FA such that it replaces the i's with svg
@@ -114,6 +115,7 @@ RfiStepperButtons.propTypes = {
     }),
   }),
   handleBack: PropTypes.func.isRequired,
+  rfiSubmitting: PropTypes.bool.isRequired,
   formik: PropTypes.shape({
     isSubmitting: PropTypes.bool.isRequired,
   }),

diff --git a/packages/app-rfi/src/core/utils/appState.js b/packages/app-rfi/src/core/utils/appState.js
@@ -113,8 +113,7 @@ export const useRfiState = props => {
     if (isLastStep) {
       setRfiSubmitting(true);
       rfiSubmit(values, submissionUrl, test, () => {
-
-      setRfiSubmitting(false);
+        setRfiSubmitting(false);
         setSuccess(true);
       });
       return;

diff --git a/packages/app-rfi/src/core/utils/submission-helpers.js b/packages/app-rfi/src/core/utils/submission-helpers.js
@@ -1,7 +1,7 @@
 // @ts-check
+import { deepCloner } from "../../../../../shared/utils";
 import { KEY } from "./constants";
 import { pushDataLayerEventToGa, setClientId } from "./google-analytics";
-import { deepCloner } from "../../../../../shared/utils";
 
 /**
  * In order to make a field not required, we set the default or blank value
@@ -95,7 +95,12 @@ function submissionSetHiddenFields(payload, test) {
   return output;
 }
 
-export const rfiSubmit = async (value, submissionUrl, test, callback = a => ({})) => {
+export const rfiSubmit = async (
+  value,
+  submissionUrl,
+  test,
+  callback = a => ({})
+) => {
   // MARSHALL FIELDS FOR THE PAYLOAD
 
   let payload = deepCloner(value);
@@ -130,14 +135,7 @@ export const rfiSubmit = async (value, submissionUrl, test, callback = a => ({})
       "Content-Type": "application/json",
     },
     body: JSON.stringify(payload),
-  }).then(async (response) => {
-    await new Promise(resolve => {
-      setTimeout(() => {
-        resolve(true);
-      }, 2000);
-    });
-    return response.json();
-  });
+  }).then(response => response.json());
 
   // Race the fetch promise against the timeout promise
   return Promise.race([fetchPromise, timeoutPromise]).then(response =>