Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use this. for property setter in c# class renderer #1874

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

marakalwa
Copy link
Contributor

@marakalwa marakalwa commented Mar 10, 2024

Description

The setter for c# class properties should use this.{propertyName} to assign values to avoid an edge case where there is a property named 'value'

Related Issue

Fixes #1862

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

Copy link

netlify bot commented Mar 10, 2024

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit d1b488d
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/65edb7983f71d300081ac512

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update the example snapshots npm run test:examples:update

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8222406080

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.303%

Totals Coverage Status
Change from base Build 8203318802: 0.0%
Covered Lines: 5994
Relevant Lines: 6325

💛 - Coveralls

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@jonaslagoni jonaslagoni merged commit 6291e04 into asyncapi:master Mar 10, 2024
16 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.0-next.36 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] C# setter for property named value prevents assignment.
4 participants