From 71c244cf3cd11f43e7a163f41b8fee924581079e Mon Sep 17 00:00:00 2001 From: Adam Chalkley Date: Wed, 10 Nov 2021 03:44:53 -0600 Subject: [PATCH] Ignore false-positive gosec G307 linting errors Issues reported after upgrading golangci-lint to v1.43.0. gosec was updated in that version from v2.8.1 to v2.9.1. refs atc0005/elbow#362 refs golangci/golangci-lint#2299 --- config/config.go | 4 ++++ config/config_test.go | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/config/config.go b/config/config.go index 3376b9c7..8f109ce4 100644 --- a/config/config.go +++ b/config/config.go @@ -231,6 +231,10 @@ func NewConfig(appVersion string) (*Config, error) { if err != nil { return nil, fmt.Errorf("unable to open config file: %v", err) } + + // #nosec G307 + // Believed to be a false-positive from recent gosec release + // https://github.com/securego/gosec/issues/714 defer func() { if err := fh.Close(); err != nil { // Ignore "file already closed" errors diff --git a/config/config_test.go b/config/config_test.go index 852d7a9a..3ca06390 100644 --- a/config/config_test.go +++ b/config/config_test.go @@ -207,6 +207,10 @@ func TestLoadConfigFileTemplate(t *testing.T) { } else { t.Log("Successfully opened config file", exampleConfigFile) } + + // #nosec G307 + // Believed to be a false-positive from recent gosec release + // https://github.com/securego/gosec/issues/714 defer func() { if err := fh.Close(); err != nil { // Ignore "file already closed" errors