Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove types option in TSConfig once Cypress fix their global types issue #38

Closed
danieldelcore opened this issue May 6, 2020 · 2 comments
Closed

Remove types option in TSConfig once Cypress fix their global types issue #38

danieldelcore opened this issue May 6, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@danieldelcore
Copy link
Contributor

storybook-addon-performance/tsconfig.json

Line 15 in e1ea11f

"types": ["gzip-js", "jest", "react", "react-dom"]

Issue thread: cypress-io/cypress#6690
PR open on Cypress: cypress-io/cypress#7194
@danieldelcore danieldelcore added the good first issue Good for newcomers label May 6, 2020
@justman00 justman00 mentioned this issue Aug 21, 2020
Merged
@davilima6
Copy link
Contributor

@danieldelcore, @justman00: may this one be closed?

@danieldelcore
Copy link
Contributor Author

Yep! Wonderful!! Thanks for letting us know @davilima6 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davilima6 @danieldelcore