Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding or removing a Droppable during a drag is currently not supported #452

Closed
nicubarbaros opened this issue Apr 18, 2018 · 5 comments
Closed

Comments

@nicubarbaros
Copy link

I couldnot see anything about this breaking change in the log of the new release.

Before 7. I could load new Droppables and my Draggable will be intact. But couldnot drop on it. Now my droppable dissapears when I am loading a new Droppable.

Have I missed something?

@lukebatchelor
Copy link
Member

Hiya,

Would you mind creating a small reproducable test case that shows what you mean?

https://codesandbox.io/s/k260nyxq9v

@nicubarbaros
Copy link
Author

nicubarbaros commented Apr 18, 2018

It will take me some time to create a reproducible test but here are 2 Gifs.

Version. 6.0.2
I am grabbing a Draggable and scrolling down. It loads the next month (a bunch of Droppables). I can't Drop (I know this), however my Draggable state it is still as a Draggable.
http://recordit.co/3UP6dzuvO6

Version 7.0.2
The same workflow, however now my Draggable disappears (it goes back to its Droppable) and I get the error.
http://recordit.co/kzY47R7133

Thank you and hopefuly this will clarifiy a little bit about the issue (If it as is supposed to be, or it is a bug).

@alexreardon
Copy link
Collaborator

This was an intentional change. It was technically not supported before so it may have had some unexpected consequences in particular cases. We now are more explicitly locking out this functionality to avoid bugs. We will be re adding this as a part of #68

@synapse
Copy link

synapse commented May 6, 2018

I'm having the same issue and I don't understand how to fix this. I have a column rows example. It gives me this error after i move a column and I try to move a row. The first time it shows me the error but the second time it works (until I move a column again).

@alexreardon
Copy link
Collaborator

Dynamically adding or removing draggables or droppables is currently not supported. We are looking at adding support in the future #484

@atlassian atlassian locked and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants