Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: cursorColor and selectionBackground #24

Open
vaskark opened this issue Aug 21, 2020 · 1 comment
Open

Suggestion: cursorColor and selectionBackground #24

vaskark opened this issue Aug 21, 2020 · 1 comment

Comments

@vaskark
Copy link

vaskark commented Aug 21, 2020

Hi. I've just noticed that Windows Terminal (1.1.2233.0) has support for cursorColor and selectionBackground (although these might not be in the stable release yet).

Just thought I'd point it out. I'd assume we'd be selecting them from the theme colors (as opposed to new ones). Not sure what the best pattern would be for all themes.

Thanks for all you work. These themes make the term look great.

@atomcorp
Copy link
Owner

Thanks for the kind words!

Most of the themes come from another repo which has to support lots of different terminals which don't support those properties. But the themes that people directly submit to this repo can include those properties, although I think only Monokai Cmder does for now.

If theme authors, or anyone, wanted to add cursorColor and selectionBackground to existing themes hosted on that other repo I'm sure we could hold those properties here, and then merge them together. I think that would be cool!

I don't know if there would be a way to automate adding them, without potentially creating hard to read combinations, but open to suggestions.

Thanks for your suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants