Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I integrate your work with PSWinTerminal? #25

Open
sassdawe opened this issue Aug 23, 2020 · 3 comments
Open

Can I integrate your work with PSWinTerminal? #25

sassdawe opened this issue Aug 23, 2020 · 3 comments

Comments

@sassdawe
Copy link

Hello,

I wrote PSWinTerminal and with the latest release it supports importing themes from the clipboard.

I'm wondering about possible integration between your collection of themes and my module.

Searching and installing themes would be a nice feature I think.

What do you think?

@atomcorp
Copy link
Owner

Hey sounds cool, adding themes to Windows Terminal is pretty clunky so that seems like a nice tool to have!

I don't know what you'd need in practice, there's a sort of endpoint I have for the frontend https://www.atomcorp.dev/api/v1/themes. It's compiled once a day on a little server I have by merging the collection at https://github.com/mbadolato/iTerm2-Color-Schemes and the themes submitted to this repo.

Let me know how I can help!

@sassdawe
Copy link
Author

That V1 endpoint looks perfect, with a simple request I can download the list. If you don't introduce any breaking changes this link to the endpoint is all what I needed.

Now I just have to figure out what to do with the data :)

One thing, can I somehow link to a specific theme on the site?
I think a Show-WTTheme cmdlet which would open the site, could offer a "preview" experience to the users.

@atomcorp
Copy link
Owner

atomcorp commented Aug 24, 2020

The only change I plan to make is to probably replace the isDark boolean with an object called meta at some point, you'll probably want to ignore those.

Yes you can link individual themes! eg https://atomcorp.github.io/themes/?theme=Operator%20Mono%20Dark

Exciting, keep me billed please!

edit: Looking at the direct links just now I noticied a bug where the background colour wasn't changed for the theme, it should be fixed now. Just in case you saw in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants