Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add support for Terminal themes apart from color schemes #87

Open
griimick opened this issue Oct 30, 2022 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@griimick
Copy link

Terminal themes are now available in Preview.
https://learn.microsoft.com/en-us/windows/terminal/customize-settings/themes

I suggest the following,

  • Add support for terminal "themes" and "color schemes" separately. Currently what we call themes in this project can be termed "color schemes". Themes define colors for Tabs and Tab Row
  • Have a separate JSON of themes apart from color schemes and use them accordingly.
  • Modify the terminal window used to preview color schemes to be more in sync with Windows Terminal design.

Let me know what you think.

@atomcorp
Copy link
Owner

Thanks for the heads up! All sounds great and welcome. PRs welcome too but if I get round to a refactor of this project I'll be sure to put it in myself.

@atomcorp atomcorp added the enhancement New feature or request label Oct 30, 2022
@griimick
Copy link
Author

Sure! I will definitely submit a draft PR first if I start on any of them.
Thanks for the project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants