Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with optional DataLoader args #308

Closed
Divide-By-0 opened this issue Jul 22, 2021 · 1 comment
Closed

Bug with optional DataLoader args #308

Divide-By-0 opened this issue Jul 22, 2021 · 1 comment

Comments

@Divide-By-0
Copy link
Contributor

Divide-By-0 commented Jul 22, 2021

It would be great if the AtomsLoader accepted a **kwargs for extra named arguments; currently, as DataLoader added an optional 'generator' argument in Pytorch-Lightning 1.3.5, I can no longer compile AtomsLoader objects such as the val_dataloader.

The full error is as follows:

in train_and_eval
    trainer.fit(model, data)
  File "/home/aayush/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 458, in fit
    self._run(model)
  File "/home/aayush/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 756, in _run
    self.dispatch()
  File "/home/aayush/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 797, in dispatch
    self.accelerator.start_training(self)
  File "/home/aayush/.local/lib/python3.8/site-packages/pytorch_lightning/accelerators/accelerator.py", line 96, in start_training
    self.training_type_plugin.start_training(trainer)
  File "/home/aayush/.local/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py", line 144, in start_training
    self._results = trainer.run_stage()
  File "/home/aayush/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 807, in run_stage
    return self.run_train()
  File "/home/aayush/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 842, in run_train
    self.run_sanity_check(self.lightning_module)
  File "/home/aayush/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1107, in run_sanity_check
    self.run_evaluation()
  File "/home/aayush/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 920, in run_evaluation
    dataloaders, max_batches = self.evaluation_loop.get_evaluation_dataloaders()
  File "/home/aayush/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/evaluation_loop.py", line 63, in get_evaluation_dataloaders
    self.trainer.reset_val_dataloader(model)
  File "/home/aayush/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/data_loading.py", line 409, in reset_val_dataloader
    self.num_val_batches, self.val_dataloaders = self._reset_eval_dataloader(model, 'val')
  File "/home/aayush/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/data_loading.py", line 357, in _reset_eval_dataloader
    dataloaders = [
  File "/home/aayush/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/data_loading.py", line 358, in <listcomp>
    self.auto_add_sampler(dl, shuffle=False, mode=self.state.stage) for dl in dataloaders if dl is not None
  File "/home/aayush/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/data_loading.py", line 142, in auto_add_sampler
    dataloader = self.replace_sampler(dataloader, sampler, mode=mode)
  File "/home/aayush/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/data_loading.py", line 213, in replace_sampler
    dataloader = type(dataloader)(**dl_args)
TypeError: __init__() got an unexpected keyword argument 'generator'

Similarly I also get an error sometimes like
TypeError: __init__() got an unexpected keyword argument 'prefetch_factor'

@Divide-By-0
Copy link
Contributor Author

Looks like this has been fixed on PL's side: Lightning-AI/pytorch-lightning#8519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant