Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused base64 strings in atclient_atkeys struct #525

Open
2 tasks
JeremyTubongbanua opened this issue Jan 21, 2025 · 1 comment
Open
2 tasks

Remove unused base64 strings in atclient_atkeys struct #525

JeremyTubongbanua opened this issue Jan 21, 2025 · 1 comment
Assignees

Comments

@JeremyTubongbanua
Copy link
Member

Image

Right now, we store 4 base64 copies of the key for writing purposes, which is wasted memory if the application code never writes the atkeys.

Things to do:

  • Remove base64 strings in atclient_atkeys
  • Ensure that atclient_atkeys writing functionality still works. To do this, prepare mbedtls RSA context and use mbedtls_pk_write_key_pem to write it to a buffer, then write that buffer to file.
@JeremyTubongbanua JeremyTubongbanua self-assigned this Jan 21, 2025
@JeremyTubongbanua
Copy link
Member Author

There's some engineering needed to be done using the mbedtls_pk_write_key_pem function, so I'm assignin 3 SP.

Making the prio a P2 because these base64 strings take up a lot of heap memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant