You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My overall reasoning is that in the atPlatform and at_c:
We represent byte buffers as unsigned char* and we don't null-terminate buffers
String are char* and they are null-terminated
base64 has becomes some hybrid of these two styles because:
We use them like strings
mbedtls treats them as byte buffers
I think because of the fact that we use base64 to serialize raw keys into strings, the best approach going forward would be to treat them like strings. It would make usage patterns elsewhere easier to identify.
The main places we would need this change are (there may be more, but these are the ones I've encountered):
atchops_base64_encode - not null-terminated but are correct type (char *)
atchops_rsa_key_generate_base64 - null-terminated but wrong type (unsigned char*)
The text was updated successfully, but these errors were encountered:
@JeremyTubongbanua would love your thoughts on this.
My overall reasoning is that in the atPlatform and at_c:
I think because of the fact that we use base64 to serialize raw keys into strings, the best approach going forward would be to treat them like strings. It would make usage patterns elsewhere easier to identify.
The main places we would need this change are (there may be more, but these are the ones I've encountered):
The text was updated successfully, but these errors were encountered: