Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitgist: Advanced menu option "open in github" should be disabled #1838

Closed
holyguster opened this issue Mar 13, 2016 · 5 comments
Closed

Gitgist: Advanced menu option "open in github" should be disabled #1838

holyguster opened this issue Mar 13, 2016 · 5 comments
Assignees
@gordonwoodhull
Labels
bug
Milestone
1.8

Comments

@holyguster
Copy link
Contributor

It tries to open the gist on github.com, whereas it should open the file(s) for the notebook under the path indicated by gist.git.root in the rcloud.conf file.
@holyguster holyguster changed the title Advanced menu item open in github broken when using gist backend Gitgist: Advanced menu option "open in github" broken when using gitgist backend Mar 13, 2016
@gordonwoodhull gordonwoodhull added this to the 1.6 milestone Mar 14, 2016
@gordonwoodhull
Copy link
Contributor

Is there anything we can do here? There is no github UI for looking at some files on the file system.

We'll probably need to disable the command in this case, unless I'm missing something.

@prateek05
Copy link
Contributor

Vote for disable. unless we want to build a UI (which is insanely a complete project itself)

@gordonwoodhull gordonwoodhull changed the title Gitgist: Advanced menu option "open in github" broken when using gitgist backend Gitgist: Advanced menu option "open in github" should be disabled Apr 14, 2016
@holyguster
Copy link
Contributor Author

Disabling is OK with me

@gordonwoodhull gordonwoodhull self-assigned this Jun 23, 2016
@gordonwoodhull gordonwoodhull modified the milestones: 1.6, 1.6.1 Jul 15, 2016
@gordonwoodhull gordonwoodhull modified the milestones: 1.6.1, 1.6.2 Aug 16, 2016
@gordonwoodhull gordonwoodhull modified the milestones: 1.6.2, 1.7 Oct 28, 2016
@gordonwoodhull gordonwoodhull modified the milestones: 1.7, 1.8 Nov 28, 2016
@gordonwoodhull gordonwoodhull mentioned this issue Apr 25, 2017
Open
@gordonwoodhull
Copy link
Contributor

github.gist.url should be falsy in this case

@gordonwoodhull
Copy link
Contributor

If both github.gist.url and github.base.url are falsy, the advanced menu item will be disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gordonwoodhull gordonwoodhull

Labels
bug
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
3 participants
@holyguster @gordonwoodhull @prateek05