Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ux-checkbox #22

Closed
1 of 2 tasks
Vheissu opened this issue Nov 24, 2016 · 13 comments
Closed
1 of 2 tasks

ux-checkbox #22

Vheissu opened this issue Nov 24, 2016 · 13 comments

Comments

@Vheissu
Copy link
Member

Vheissu commented Nov 24, 2016

Implement the ux-checkbox component for Material and iOS design.

  • Material Design
  • iOS Design
@Vheissu
Copy link
Member Author

Vheissu commented Nov 24, 2016

I'll take this one @EisenbergEffect if you can assign it to me.

@serifine
Copy link
Contributor

serifine commented Apr 5, 2017

@Vheissu are you still working on this? I am looking to snag a couple quick components to knock out.

@serifine serifine self-assigned this Apr 6, 2017
@serifine serifine removed their assignment Apr 15, 2017
@dspublic
Copy link

dspublic commented May 2, 2017

@ZHollingshead I tried your ux-checkbox component with custom string value. The "delete this.checked" isn't clears the property. Would not the "this.checked=null" be better?

@serifine
Copy link
Contributor

serifine commented May 2, 2017

@dspublic yes, it appears you are correct. I am looking into this, thanks for the catch!

@serifine
Copy link
Contributor

serifine commented May 2, 2017

@dspublic I just pushed a fix to master.

@dspublic
Copy link

dspublic commented May 3, 2017

@ZHollingshead Thank you for quick fix and response. Let me take a feature suggestion, what I implemented in my checkbox control.
There's a valueOn (value-on default=true) and valueOff (value-off default=false) and value (checked in your code) controll property.
If value==valueOn then value=valueOff
elseIf value==valueOff or value==null then value=valueOn
else value=null (third state)
In this case we have a value for state on and off, and a null for third one.
I think, your solution is close enough to this logic. What do you mean?

@serifine
Copy link
Contributor

serifine commented May 3, 2017

So if I understand correctly you would like to add additional values to be able to set a value during the unchecked state, is this correct? If so I would probably just add the unchecked state, and let value continue to represent the checked state.

<ux-checkbox value="foo" unchecked-value="bar"></ux-checkbox>

@dspublic
Copy link

dspublic commented May 3, 2017

@ZHollingshead Yes, that's correct. It's exactly what I want to suggest.
Thanks for your selfless work in this project. :-)

@serifine
Copy link
Contributor

serifine commented Sep 1, 2017

Issue moved to aurelia/ux-components #12 via ZenHub

@serifine serifine reopened this Oct 6, 2017
@veikkoeeva
Copy link

veikkoeeva commented Feb 21, 2018

@ZHollingshead A question, is https://aux-demo.firebaseapp.com/checkbox missing a design component only? It appears there are other components too that look like implemented, but having tickets open here.

@serifine
Copy link
Contributor

@veikkoeeva what do you mean by design component?

A list of all the component packages can be seen here:
Source Code: https://github.com/aurelia/ux/tree/master/packages
Feature List: https://github.com/aurelia/ux/wiki/Feature-List

@veikkoeeva
Copy link

@ZHollingshead I mean if I read correctly this -- and some other tickets -- that the pending work is related to iOS and this isn't something that's lingering in open state. It appears the case is such that this indeed is pending on some further work, though the component is useable already.

@serifine
Copy link
Contributor

The component is useable as is. The design feature will not be a separate component, that will be part of the @aurelia-ux/core package. Work on this functionality is not yet complete.

@serifine serifine closed this as completed Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants