-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ux-checkbox #22
Comments
I'll take this one @EisenbergEffect if you can assign it to me. |
@Vheissu are you still working on this? I am looking to snag a couple quick components to knock out. |
@ZHollingshead I tried your ux-checkbox component with custom string value. The "delete this.checked" isn't clears the property. Would not the "this.checked=null" be better? |
@dspublic yes, it appears you are correct. I am looking into this, thanks for the catch! |
@dspublic I just pushed a fix to master. |
@ZHollingshead Thank you for quick fix and response. Let me take a feature suggestion, what I implemented in my checkbox control. |
So if I understand correctly you would like to add additional values to be able to set a value during the unchecked state, is this correct? If so I would probably just add the unchecked state, and let value continue to represent the checked state. <ux-checkbox value="foo" unchecked-value="bar"></ux-checkbox> |
@ZHollingshead Yes, that's correct. It's exactly what I want to suggest. |
Issue moved to aurelia/ux-components #12 via ZenHub |
@ZHollingshead A question, is https://aux-demo.firebaseapp.com/checkbox missing a design component only? It appears there are other components too that look like implemented, but having tickets open here. |
@veikkoeeva what do you mean by design component? A list of all the component packages can be seen here: |
@ZHollingshead I mean if I read correctly this -- and some other tickets -- that the pending work is related to iOS and this isn't something that's lingering in open state. It appears the case is such that this indeed is pending on some further work, though the component is useable already. |
The component is useable as is. The design feature will not be a separate component, that will be part of the |
Implement the ux-checkbox component for Material and iOS design.
The text was updated successfully, but these errors were encountered: